spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6773][Tests]Fix RAT checks still passed...
Date Thu, 09 Apr 2015 11:00:43 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5421#issuecomment-91194954
  
    Looking again at the rest of the script, I don't see the point of `if [[ ! -f "$rat_jar"
]]; then`, since it's redundant with the check that follows. Both enclose the same code (excepting
that final print statement, which doesn't matter). @ScrapCodes is that right? https://github.com/apache/spark/commit/21109fbab0ded4f73cf4f8816859c76f125adfea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message