spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5338][MESOS] Add cluster mode support f...
Date Wed, 08 Apr 2015 22:06:13 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5144#discussion_r28018789
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala
---
    @@ -54,175 +45,32 @@ import org.apache.spark.deploy.ClientArguments._
      *
      * @param host the address this server should bind to
      * @param requestedPort the port this server will attempt to bind to
    + * @param masterConf the conf used by the Master
      * @param masterActor reference to the Master actor to which requests can be sent
      * @param masterUrl the URL of the Master new drivers will attempt to connect to
    - * @param masterConf the conf used by the Master
      */
     private[deploy] class StandaloneRestServer(
    -    host: String,
    -    requestedPort: Int,
    +    val host: String,
    +    val requestedPort: Int,
    +    val masterConf: SparkConf,
    --- End diff --
    
    do these need to be `val`? (i.e. can they be private?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message