spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5213] [SQL] Pluggable SQL Parser Suppor...
Date Wed, 08 Apr 2015 21:05:58 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4015#discussion_r28013173
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -154,6 +230,18 @@ class SQLContext(@transient val sparkContext: SparkContext)
       @transient
       protected[sql] val defaultSession = createSession()
     
    +  // Sub class may need to overwrite the following 2 functions custom sql dialect parser
support
    +
    +  protected[sql] def dialectClassName = if (conf.dialect == "sql") {
    +    classOf[DefaultSQLDialect].getCanonicalName
    +  } else {
    +    conf.dialect
    +  }
    +
    +  protected[sql] def resetSQLDialect() {
    +    setConf(SQLConf.DIALECT, "sql")
    +  }
    --- End diff --
    
    Do we really need a special reset function?  There is already logic to clear configuration
when testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message