spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...
Date Tue, 07 Apr 2015 20:21:36 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4435#discussion_r27916000
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
    @@ -32,28 +32,19 @@ private[ui] class RDDPage(parent: StorageTab) extends WebUIPage("rdd")
{
       def render(request: HttpServletRequest): Seq[Node] = {
         val parameterId = request.getParameter("id")
         require(parameterId != null && parameterId.nonEmpty, "Missing id parameter")
    -
         val rddId = parameterId.toInt
    -    val storageStatusList = listener.storageStatusList
    -    val rddInfo = listener.rddInfoList.find(_.id == rddId).getOrElse {
    -      // Rather than crashing, render an "RDD Not Found" page
    -      return UIUtils.headerSparkPage("RDD Not Found", Seq[Node](), parent)
    +    val rddStorageInfo = AllRDDResource.getRDDStorageInfo(rddId, listener,
    --- End diff --
    
    nit: indentation makes this hard to read. I'd suggest:
    
        val rddStorageInfo = AllRDDResource
          .getRDDStorageInfo(rddId, listener, includeDetails = true)
          .getOrElse {
            // Rather than crashing, render an "RDD Not Found" page
            return UIUtils.headerSparkPage("RDD Not Found", Seq[Node](), parent)
          }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message