spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5654] Integrate SparkR
Date Tue, 07 Apr 2015 02:32:20 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5096#discussion_r27847834
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala ---
    @@ -0,0 +1,222 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.api.r
    +
    +import java.io.{ByteArrayInputStream, ByteArrayOutputStream, DataInputStream, DataOutputStream}
    +
    +import scala.collection.mutable.HashMap
    +
    +import io.netty.channel.ChannelHandler.Sharable
    +import io.netty.channel.{ChannelHandlerContext, SimpleChannelInboundHandler}
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.api.r.SerDe._
    +
    +/**
    + * Handler for RBackend
    + * TODO: This is marked as sharable to get a handle to RBackend. Is it safe to re-use
    + * this across connections ?
    + */
    +@Sharable
    +private[r] class RBackendHandler(server: RBackend)
    +  extends SimpleChannelInboundHandler[Array[Byte]] with Logging {
    +
    +  override def channelRead0(ctx: ChannelHandlerContext, msg: Array[Byte]) {
    --- End diff --
    
    Thanks  - Done now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message