spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6568] spark-shell.cmd --jars option doe...
Date Fri, 03 Apr 2015 12:17:49 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5347#discussion_r27726576
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1651,7 +1651,7 @@ private[spark] object Utils extends Logging {
       /**
        * Format a Windows path such that it can be safely passed to a URI.
        */
    -  def formatWindowsPath(path: String): String = path.replace("\\", "/")
    +  def formatWindowsPath(path: String): String = path.replace("\\", "/").replace(" ",
"%20")
    --- End diff --
    
    Hm, is this specific to Windows, even? if I had a path with a space on Linux it would
fail similarly, I'd imagine? I bet we dont' get that case right either.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message