spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4346][SPARK-3596][YARN] Commonize the m...
Date Thu, 02 Apr 2015 21:55:23 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/5305#issuecomment-89056843
  
    Hi @Sephiroth-Lin this looks good for the most part. The only reason why I didn't merge
these code paths initially is because the loop here checks on `stopping`, and I didn't want
to pass the boolean into `monitorApplication`. However, on second examination this is a daemon
thread anyway, so it will eventually exit regardless of whether the backend has been stopped.
    
    Once you address @witgo's comment I will merge this thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message