Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: rxin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-5129-spark@git.apache.org>
In-Reply-To: <git-pr-5129-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-6452] [SQL] Checks for missing
 attribut...
Content-Type: text/plain
Message-Id: <20150323033251.08EB2E0551@git1-us-west.apache.org>
Date: Mon, 23 Mar 2015 03:32:51 +0000 (UTC)

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5129#discussion_r26912927
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -85,14 +85,19 @@ class CheckAnalysis {
     
                 cleaned.foreach(checkValidAggregateExpression)
     
    +          case _ => // Fallbacks to the following checks
    --- End diff --
    
    ah ok makes sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org