Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 192C1108C5 for ; Sun, 15 Mar 2015 15:20:59 +0000 (UTC) Received: (qmail 58877 invoked by uid 500); 15 Mar 2015 15:20:58 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 58853 invoked by uid 500); 15 Mar 2015 15:20:58 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 58840 invoked by uid 99); 15 Mar 2015 15:20:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Mar 2015 15:20:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0A5DBE1072; Sun, 15 Mar 2015 15:20:57 +0000 (UTC) From: chenghao-intel To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-6215][SQL] Shorten apply and update fun... Content-Type: text/plain Message-Id: <20150315152058.0A5DBE1072@git1-us-west.apache.org> Date: Sun, 15 Mar 2015 15:20:57 +0000 (UTC) Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4940#issuecomment-81089066 See https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala#L67 Usually we don't the the validity of `ordinal` within the callee, the caller should take care of that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org