Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: tdas <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-4961-spark@git.apache.org>
In-Reply-To: <git-pr-4961-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-6211][Streaming] Add Python Kafka
 API u...
Content-Type: text/plain
Message-Id: <20150312192222.D465FE18E5@git1-us-west.apache.org>
Date: Thu, 12 Mar 2015 19:22:22 +0000 (UTC)

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4961#discussion_r26335422
  
    --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaTestUtils.scala ---
    @@ -0,0 +1,256 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.streaming.kafka
    +
    +import java.io.File
    +import java.lang.{Integer => JInt}
    +import java.net.InetSocketAddress
    +import java.util.{Map => JMap}
    +import java.util.Properties
    +import java.util.concurrent.TimeoutException
    +
    +import scala.annotation.tailrec
    +import scala.language.postfixOps
    +import scala.util.Random
    +
    +import kafka.admin.AdminUtils
    +import kafka.common.KafkaException
    +import kafka.producer.{KeyedMessage, Producer, ProducerConfig}
    +import kafka.serializer.StringEncoder
    +import kafka.server.{KafkaConfig, KafkaServer}
    +import kafka.utils.ZKStringSerializer
    +import org.apache.zookeeper.server.{NIOServerCnxnFactory, ZooKeeperServer}
    +import org.I0Itec.zkclient.ZkClient
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.streaming.Time
    +import org.apache.spark.util.Utils
    +
    +/**
    + * This is a helper class for Kafka test suites. This has the functionality to set up
    + * and tear down local Kafka servers, and to push data using Kafka producers.
    + */
    +private class KafkaTestUtils extends Logging {
    +
    +  // Zookeeper related configurations
    +  private val zkHost = "localhost"
    +  private var zkPort: Int = 0
    +  private val zkConnectionTimeout = 6000
    +  private val zkSessionTimeout = 6000
    +
    +  private var zookeeper: EmbeddedZookeeper = _
    +
    +  var zkClient: ZkClient = _
    +
    +  // Kafka broker related configurations
    +  private val brokerHost = "localhost"
    +  private var brokerPort = 9092
    +  private var brokerConf: KafkaConfig = _
    +
    +  // Kafka broker server
    +  private var server: KafkaServer = _
    +
    +  // Kafka producer
    +  private var producer: Producer[String, String] = _
    +
    +  // Flag to test whether the system is correctly started
    +  private var zkReady = false
    +  private var brokerReady = false
    +
    +  def zkAddress: String = {
    +    assert(zkReady, "Zookeeper not setup yet or already torn down, cannot get zookeeper address")
    +    s"$zkHost:$zkPort"
    +  }
    +
    +  def brokerAddress: String = {
    +    assert(brokerReady, "Kafka not setup yet or already torn down, cannot get broker address")
    +    s"$brokerHost:$brokerPort"
    +  }
    +
    +  /** Set up the Embedded Zookeeper server and get the proper Zookeeper port */
    +  def setupEmbeddedZookeeper(): Unit = {
    +    // Zookeeper server startup
    +    zookeeper = new EmbeddedZookeeper(s"$zkHost:$zkPort")
    +    // Get the actual zookeeper binding port
    +    zkPort = zookeeper.actualPort
    +    zkReady = true
    +    zkClient = new ZkClient(zkAddress, zkSessionTimeout, zkConnectionTimeout, ZKStringSerializer)
    +  }
    +
    +  /** Set up the Embedded Kafka server */
    +  def setupEmbeddedKafkaServer(): Unit = {
    +    assert(zkReady, "Zookeeper should be set up beforehand")
    +    // Kafka broker startup
    +    var bindSuccess: Boolean = false
    +    while(!bindSuccess) {
    +      try {
    +        brokerConf = new KafkaConfig(brokerConfigure)
    +        server = new KafkaServer(brokerConf)
    +        server.startup()
    +        bindSuccess = true
    +      } catch {
    +        case e: KafkaException =>
    +          if (e.getMessage != null && e.getMessage.contains("Socket server failed to bind to")) {
    +            brokerPort += 1
    +          }
    +        case e: Exception => throw new Exception("Kafka server create failed", e)
    +      }
    +    }
    +
    +    Thread.sleep(2000)
    +    brokerReady = true
    +  }
    +
    +  /** Tear down the whole servers, including Kafka broker and Zookeeper */
    +  def tearDownEmbeddedServers(): Unit = {
    +    brokerReady = false
    +    zkReady = false
    +
    +    if (producer != null) {
    +      producer.close()
    +      producer = null
    +    }
    +
    +    if (server != null) {
    +      server.shutdown()
    +      server = null
    +    }
    +
    +    brokerConf.logDirs.foreach { f => Utils.deleteRecursively(new File(f)) }
    +
    +    if (zkClient != null) {
    +      zkClient.close()
    +      zkClient = null
    +    }
    +
    +    if (zookeeper != null) {
    +      zookeeper.shutdown()
    +      zookeeper = null
    +    }
    +  }
    +
    +  /** Create a Kafka topic and wait until it propagated to the whole cluster */
    +  def createTopic(topic: String): Unit = {
    +    AdminUtils.createTopic(zkClient, topic, 1, 1)
    +    // wait until metadata is propagated
    +    waitUntilMetadataIsPropagated(topic, 0)
    +  }
    +
    +  /** Java function for sending messages to the Kafka broker */
    --- End diff --
    
    `Java-friendly function`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org