Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: liancheng <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-4945-spark@git.apache.org>
In-Reply-To: <git-pr-4945-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-6201] [SQL] promote string and do
 widen...
Content-Type: text/plain
Message-Id: <20150309171121.81CD2E1808@git1-us-west.apache.org>
Date: Mon,  9 Mar 2015 17:11:21 +0000 (UTC)

Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4945#discussion_r26054740
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala ---
    @@ -269,6 +285,14 @@ trait HiveTypeCoercion {
             i.makeCopy(Array(Cast(a, StringType), b.map(Cast(_, StringType))))
           case i @ In(a, b) if a.dataType == TimestampType && b.forall(_.dataType == DateType) =>
             i.makeCopy(Array(Cast(a, StringType), b.map(Cast(_, StringType))))
    +      case i @ In(a, b) if a.dataType == StringType
    +        && b.exists(_.dataType.isInstanceOf[NumericType]) =>
    +        i.makeCopy(Array(Cast(a, DoubleType), b))
    +      case i @ In(a, b) if b.exists(_.dataType == StringType)
    +        && a.dataType.isInstanceOf[NumericType] =>
    +        i.makeCopy(Array(a, b.map(_.dataType match{
    +          case StringType => Cast(a, DoubleType)
    --- End diff --
    
    Same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org