spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6614] OutputCommitCoordinator should cl...
Date Tue, 31 Mar 2015 22:38:44 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5276#discussion_r27530342
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala
---
    @@ -113,9 +113,11 @@ private[spark] class OutputCommitCoordinator(conf: SparkConf) extends
Logging {
             logInfo(
               s"Task was denied committing, stage: $stage, partition: $partition, attempt:
$attempt")
           case otherReason =>
    -        logDebug(s"Authorized committer $attempt (stage=$stage, partition=$partition)
failed;" +
    -          s" clearing lock")
    -        authorizedCommitters.remove(partition)
    +        if (authorizedCommitters.get(partition).exists(_ == attempt)) {
    --- End diff --
    
    isn't authorizedCommitters a map keyed by partition? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message