spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stephenh <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6560][CORE] Do not suppress exceptions ...
Date Tue, 31 Mar 2015 20:47:33 GMT
Github user stephenh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5223#discussion_r27521404
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
    @@ -729,7 +729,7 @@ private[spark] class ExternalSorter[K, V, C](
           var out: FileOutputStream = null
           var in: FileInputStream = null
           val writeStartTime = System.nanoTime
    -      try {
    +      util.Utils.tryWithSafeFinally {
    --- End diff --
    
    Good point pushing `in` into the loop; done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message