spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6492][CORE] SparkContext.stop() can dea...
Date Tue, 31 Mar 2015 02:54:14 GMT
Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/5277#issuecomment-87911626
  
    > Timeouts are one way to fix this, but I wonder if we could also try to remove the
circular wait condition by modifying EventLoop so that stopped is set before we call onError.
This would prevent calls to EventLoop.stop() from blocking while the event loop is in the
process of shutting down, which should prevent this race.
    
    Do you mean calling `EventLoop.stop` in dagScheduler.onError? I just found that calling
`EventLoop.stop` in `EventLoop.onReceive` and `EventLoop.onError` won't call onStop. I will
fix it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message