spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [spark] [SPARK-6168] Expose some of the collec...
Date Wed, 25 Mar 2015 21:48:29 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5084#issuecomment-86228605
  
    I think a lot of that is already clear, and I read this as several vetoes, which is why
it was closed. Sure, another round of discussion, but unless that changes everyone's views,
I think that has to be reflected as a resolution rather than keep this open as a wish, even
if one person really wants it. There are lots of things lots of people really want Spark to
do for them.
    
    Why would you need something from Spark, but not mind if it were taken away?  
    The right place for this is an external library, which all consumers could consume. There
are already such libraries, and using them isn't at all constrained by what Spark does or
doesn't do.
    I don't understand the point about shading, since Guava was shaded exactly so you could
bring your own version freely independent of what Spark has.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message