spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6521][Core]executors in the same node r...
Date Wed, 25 Mar 2015 19:36:31 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5178#discussion_r27157449
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
    @@ -81,7 +89,38 @@ private[spark] class DiskBlockManager(blockManager: BlockManager, conf:
SparkCon
         new File(subDir, filename)
       }
     
    -  def getFile(blockId: BlockId): File = getFile(blockId.name)
    +  /** Looks up a file by blockManagerId */
    +  // This method should be kept in sync with
    +  // org.apache.spark.network.shuffle.StandaloneShuffleBlockManager#getFile().
    --- End diff --
    
    It seems that the changes here caused this to be out of sync, right? Do we want to make
the same changes in `StandaloneShuffleBlockManager` too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message