spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6375][SQL] Fix formatting of error mess...
Date Tue, 24 Mar 2015 19:30:57 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5155#discussion_r27064382
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
    @@ -42,6 +42,13 @@ abstract class NamedExpression extends Expression {
       def exprId: ExprId
     
       /**
    +   * Returns a dot separated fully qualified name for this attribute.  Given that there
can be
    +   * multiple qualifiers, it is possible that there are other possible way to refer to
this
    +   * attribute.
    +   */
    +  def qualifiedName: String = (qualifiers.headOption.toSeq :+ name).mkString(".")
    --- End diff --
    
    Also, add TODO at here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message