spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...
Date Tue, 24 Mar 2015 12:51:37 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5115#discussion_r27023852
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -792,6 +793,11 @@ private[spark] object Utils extends Logging {
       lazy val localIpAddress: String = findLocalIpAddress()
       lazy val localIpAddressHostname: String = getAddressHostName(localIpAddress)
     
    +  def localIpURI(): String = {
    --- End diff --
    
    I don't think it's worth it. Right now the PR is changing behavior, which is a lot worse.
I think this change can be concluded quite simply, right? In the 1-2 places where the host
address / IP needs to be escaped to be part of a URI, use the `InetAddresses` utility to do
so. Adding a utility method to call a utility method doesn't seem like a win.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message