spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4411][UI]Add kill link for jobs in the ...
Date Tue, 24 Mar 2015 03:07:31 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4823#discussion_r27000488
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -42,6 +42,18 @@ private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("")
{
         }
     
         def makeRow(job: JobUIData): Seq[Node] = {
    +      // scalastyle:off
    +      val killLink = if (killEnabled) {
    +        val killLinkUri = s"${UIUtils.prependBaseUri(parent.basePath)}/jobs/job/kill?"
+
    +          s"id=${job.jobId}&terminate=true"
    +        val confirm = "return window.confirm(" +
    +          s"'Are you sure you want to kill job ${job.jobId} ?');"
    +        <span class="kill-link">
    +          (<a href={killLinkUri} onclick={confirm}>kill</a>)
    +        </span>
    +      }
    +      // scalastyle:on
    --- End diff --
    
    do you need to disable scalastyle here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message