spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SQL] Checking data types when resolving types
Date Sun, 22 Mar 2015 08:38:28 GMT
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/4685#issuecomment-84558771
  
    I like the idea of compile time type checking. This could be generalized to all UDFs.
For example, `Like` and  `RLike` should also check whether their arguments are of `StringType`.
Right now we do necessary (?) implicit type conversions for some commonly used functions in
`FunctionArgumentConversion`. It should make more sense to move these conversions into all
those individual function definitions and add type checking there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message