spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...
Date Wed, 18 Mar 2015 03:17:00 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5059#discussion_r26635598
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
    @@ -142,7 +142,39 @@ class HadoopTableReader(
           partitionToDeserializer: Map[HivePartition,
           Class[_ <: Deserializer]],
           filterOpt: Option[PathFilter]): RDD[Row] = {
    -    val hivePartitionRDDs = partitionToDeserializer.map { case (partition, partDeserializer)
=>
    +    // SPARK-5068:get FileStatus and do the filtering locally when the path is not exists
    +
    +      var existPathSet =collection.mutable.Set[String]()
    +      var pathPatternSet = collection.mutable.Set[String]()
    +
    +     val hivePartitionRDDs = partitionToDeserializer.filter {
    +            case (partition, partDeserializer) =>
    +
    +            def updateExistPathSetByPathPattern(pathPatternStr:String ){
    +              val pathPattern = new Path(pathPatternStr)
    +              val fs = pathPattern.getFileSystem(sc.hiveconf)
    +              val matchs = fs.globStatus(pathPattern);
    +              matchs.map( fileStatus =>(existPathSet+= fileStatus.getPath.toString))
    --- End diff --
    
    no space after (
    space after =>
    space before +=
    no inner ()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message