spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-6338 [CORE] Use standard temp dir mechan...
Date Mon, 16 Mar 2015 22:50:14 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5029#discussion_r26535353
  
    --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
    @@ -370,7 +369,7 @@ class UtilsSuite extends FunSuite with ResetSystemProperties {
           assert(sparkConf.getBoolean("spark.test.fileNameLoadA", false) === true)
           assert(sparkConf.getInt("spark.test.fileNameLoadB", 1) === 2)
         } finally {
    -      outFile.delete()
    +      Utils.deleteRecursively(tmpDir)
    --- End diff --
    
    Is this necessary now that we're using `createTempDir`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message