spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6345][STREAMING][MLLIB] Fix for trainin...
Date Mon, 16 Mar 2015 19:20:30 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5037#discussion_r26518380
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
    @@ -114,7 +114,7 @@ abstract class StreamingLinearAlgorithm[
         if (model.isEmpty) {
           throw new IllegalArgumentException("Model must be initialized before starting prediction.")
         }
    -    data.map(model.get.predict)
    --- End diff --
    
    `.map(model.get.predict)` executes `model.get.predict` directly. Check the following:
    
    ~~~scala
    val rdd = sc.parallelize(0 until 10)
    var func = (x: Int) => 1
    val rdd1 = rdd.map(func)
    val rdd2 = rdd.map(x => func(x))
    func = (x: Int) => 2
    rdd1.collect()
    rdd2.collect()
    ~~~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message