spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenghao-intel <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6315] [SQL] Also tries the case class s...
Date Sun, 15 Mar 2015 15:25:12 GMT
Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5034#discussion_r26448690
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
    @@ -672,7 +672,11 @@ private[sql] object ParquetRelation2 {
             .getKeyValueMetaData
             .toMap
             .get(RowReadSupport.SPARK_METADATA_KEY)
    -        .map(DataType.fromJson(_).asInstanceOf[StructType])
    +        .map { serializedSchema =>
    +          Try(DataType.fromJson(serializedSchema))
    --- End diff --
    
    How about output a log for the deprecation also? Just to remind people to use the `Json`
style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message