spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From baishuo <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...
Date Fri, 13 Mar 2015 04:11:46 GMT
Github user baishuo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3895#discussion_r26363950
  
    --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala ---
    @@ -297,7 +297,7 @@ private[hive] object HiveShim {
       def getStatsSetupConstRawDataSize = StatsSetupConst.RAW_DATA_SIZE
     
       def createDefaultDBIfNeeded(context: HiveContext) = {
    -    context.runSqlHive("CREATE DATABASE default")
    +    context.runSqlHive("CREATE DATABASE IF NOT EXISTS default")
    --- End diff --
    
    I think we do not need to modify Shim12, Since there is not the same function in Shim12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message