spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koeninger <>
Subject [GitHub] spark pull request: [SPARK-6051][Streaming] Add ZooKeeper offest p...
Date Tue, 10 Mar 2015 18:21:27 GMT
Github user koeninger commented on a diff in the pull request:
    --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
    @@ -118,6 +123,7 @@ class DirectKafkaInputDStream[
           context.sparkContext, kafkaParams, currentOffsets, untilOffsets, messageHandler)
         currentOffsets = => kv._1 -> kv._2.offset)
    +    offsetMap += ((validTime, currentOffsets))
    --- End diff --
    if it's not checkpointed, is rememberDuration guaranteed to be high enough that the rdd
hasn't already been cleared out by the time the batch completion listener runs?
    If that's all ok, sure, seems much better to me than keeping the redundant info around.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message