spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...
Date Fri, 06 Mar 2015 21:04:39 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r25977866
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -17,20 +17,21 @@
     
     package org.apache.spark.deploy.yarn
     
    -import java.net.{InetAddress, UnknownHostException, URI, URISyntaxException}
    +import java.io.File
    +import java.net.{InetAddress, UnknownHostException, URI}
     import java.nio.ByteBuffer
    +import java.util.UUID
     
     import scala.collection.JavaConversions._
     import scala.collection.mutable.{ArrayBuffer, HashMap, ListBuffer, Map}
     import scala.util.{Try, Success, Failure}
     
    -import com.google.common.base.Objects
    +import com.google.common.base.{Preconditions, Objects}
    --- End diff --
    
    Also, you added the import but didn't really use `Preconditions`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message