spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6030][CORE] Don't alignSize the compute...
Date Fri, 06 Mar 2015 19:11:00 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4783#discussion_r25968891
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala ---
    @@ -49,6 +49,11 @@ private[spark] object SizeEstimator extends Logging {
       private val FLOAT_SIZE   = 4
       private val DOUBLE_SIZE  = 8
     
    +  // Fields can be primitive types, sizes are: 1, 2, 4, 8. Or fields can be pointers.
The size of 
    +  // a point is 4 or 8 depends on the JVM (32-bit or 64-bit) and UseCompressedOops flag.
    --- End diff --
    
    Nits:
    
    size of point -> size of a pointer
    depends on the JVM -> depending on the JVM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message