spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-4705:[ For Cluster mode ] Pull request f...
Date Tue, 03 Mar 2015 00:06:28 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4845#discussion_r25652037
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -385,8 +386,8 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
       // Optionally log Spark events
       private[spark] val eventLogger: Option[EventLoggingListener] = {
         if (isEventLogEnabled) {
    -      val logger =
    -        new EventLoggingListener(applicationId, eventLogDir.get, conf, hadoopConfiguration)
    +      val logger = new EventLoggingListener(
    +          applicationId, applicationAttemptId, eventLogDir.get, conf, hadoopConfiguration)
    --- End diff --
    
    nit: indented too far


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message