Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 031931798C for ; Mon, 9 Feb 2015 05:03:47 +0000 (UTC) Received: (qmail 25604 invoked by uid 500); 8 Feb 2015 23:37:07 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 25578 invoked by uid 500); 8 Feb 2015 23:37:06 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 25567 invoked by uid 99); 8 Feb 2015 23:37:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Feb 2015 23:37:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6E766E03A1; Sun, 8 Feb 2015 23:37:06 +0000 (UTC) From: srowen To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org Message-ID: Subject: [GitHub] spark pull request: SPARK-4405 [MLLIB] Matrices.* construction met... Content-Type: text/plain Date: Sun, 8 Feb 2015 23:37:06 +0000 (UTC) GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/4461 SPARK-4405 [MLLIB] Matrices.* construction methods should check for rows x cols overflow Check that size of dense matrix array is not beyond Int.MaxValue in Matrices.* methods. @jkbradley this should be an easy one. Review and/or merge as you see fit. You can merge this pull request into a Git repository by running: $ git pull https://github.com/srowen/spark SPARK-4405 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/4461.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4461 ---- commit c67574e38460e7b20d74d0e983a978309ab524a3 Author: Sean Owen Date: 2015-02-08T23:35:49Z Check that size of dense matrix array is not beyond Int.MaxValue in Matrices.* methods ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org