Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: andrewor14 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-3629-spark@git.apache.org>
In-Reply-To: <git-pr-3629-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-4777][CORE] Some block memory
 after unr...
Content-Type: text/plain
Message-Id: <20150227064429.F165AE0E3C@git1-us-west.apache.org>
Date: Fri, 27 Feb 2015 06:44:29 +0000 (UTC)

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3629#discussion_r25490244
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
    @@ -381,6 +395,8 @@ private[spark] class MemoryStore(blockManager: BlockManager, maxMemory: Long)
         }
     
         // Take into account the amount of memory currently occupied by unrolling blocks
    +    // and minus the pending unroll memory for that block on current thread.
    +    val threadId = Thread.currentThread().getId
    --- End diff --
    
    where is this variable used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org