Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: chenghao-intel <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-4527-spark@git.apache.org>
In-Reply-To: <git-pr-4527-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-5738] [SQL] Reuse mutable row for
 each ...
Content-Type: text/plain
Message-Id: <20150211153536.60544E01CB@git1-us-west.apache.org>
Date: Wed, 11 Feb 2015 15:35:36 +0000 (UTC)

Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4527#discussion_r24503655
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/json/JsonRDD.scala ---
    @@ -39,7 +39,19 @@ private[sql] object JsonRDD extends Logging {
           json: RDD[String],
           schema: StructType,
           columnNameOfCorruptRecords: String): RDD[Row] = {
    -    parseJson(json, columnNameOfCorruptRecords).map(parsed => asRow(parsed, schema))
    +    // Reuse the mutable row for each record, however we still need to 
    +    // create a new row for every nested struct type in each record
    +    val mutableRow = new SpecificMutableRow(schema.fields.map(_.dataType))
    +    parseJson(json, columnNameOfCorruptRecords).mapPartitions( iter => {
    +      iter.map { parsed =>
    +        schema.fields.zipWithIndex.foreach {
    --- End diff --
    
    This is duplicated with the function `asRow`, can we add additional parameter for `asRow`, says
    ```
    def asRow(json: Map[String,Any], schema: StructType, mutable: GenericMutableRow = null): Row = {
      row = if (mutable == null) {
         new GenericMutableRow(schema.fields.length)
      } else {
        mutable
      }
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org