spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5760][SPARK-5761] Fix standalone rest p...
Date Thu, 12 Feb 2015 07:55:51 GMT
GitHub user andrewor14 opened a pull request:

    https://github.com/apache/spark/pull/4557

    [SPARK-5760][SPARK-5761] Fix standalone rest protocol corner cases + revamp tests

    The changes are summarized in the commit message. Test or test-related code accounts for
90% of the lines changed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrewor14/spark rest-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4557
    
----
commit 00999a85ffa78ab4776b3ef86da1eba475f223a9
Author: Andrew Or <andrew@databricks.com>
Date:   2015-02-12T07:43:25Z

    Revamp tests + fix a few corner cases
    
    Major changes include:
    
    (1) The server used to always send the JSON to the servlet's
        output stream. However, if the response code is not 200,
        the client must actually read from the error stream. Now
        the server writes to the correct stream depending on the
        response code.
    
    (2) If the server throws an internal exception, both the
        output stream and the error stream on the client side
        is null (not empty). This was not previously accounted
        for and could lead to NPEs.
    
    (3) The default error handling servlet did not match the
        URL cases correctly, because there used to always be
        an empty string in the list. This is now filtered out.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message