spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brennonyork <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5343][GraphX]: ShortestPaths traverses ...
Date Mon, 09 Feb 2015 19:03:59 GMT
GitHub user brennonyork opened a pull request:

    https://github.com/apache/spark/pull/4478

    [SPARK-5343][GraphX]: ShortestPaths traverses backwards

    Corrected the logic with ShortestPaths so that the calculation will run forward rather
than backwards. Output before looked like:
    
    ```scala
    import org.apache.spark.graphx._
    val g = Graph(sc.makeRDD(Array((1L,""), (2L,""), (3L,""))), sc.makeRDD(Array(Edge(1L,2L,""),
Edge(2L,3L,""))))
    lib.ShortestPaths.run(g,Array(3)).vertices.collect
    // res0: Array[(org.apache.spark.graphx.VertexId, org.apache.spark.graphx.lib.ShortestPaths.SPMap)]
= Array((1,Map()), (3,Map(3 -> 0)), (2,Map()))
    lib.ShortestPaths.run(g,Array(1)).vertices.collect
    // res1: Array[(org.apache.spark.graphx.VertexId, org.apache.spark.graphx.lib.ShortestPaths.SPMap)]
= Array((1,Map(1 -> 0)), (3,Map(1 -> 2)), (2,Map(1 -> 1)))
    ```
    
    And new output after the changes looks like:
    
    ```scala
    import org.apache.spark.graphx._
    val g = Graph(sc.makeRDD(Array((1L,""), (2L,""), (3L,""))), sc.makeRDD(Array(Edge(1L,2L,""),
Edge(2L,3L,""))))
    lib.ShortestPaths.run(g,Array(3)).vertices.collect
    // res0: Array[(org.apache.spark.graphx.VertexId, org.apache.spark.graphx.lib.ShortestPaths.SPMap)]
= Array((1,Map(3 -> 2)), (2,Map(3 -> 1)), (3,Map(3 -> 0)))
    lib.ShortestPaths.run(g,Array(1)).vertices.collect
    // res1: Array[(org.apache.spark.graphx.VertexId, org.apache.spark.graphx.lib.ShortestPaths.SPMap)]
= Array((1,Map(1 -> 0)), (2,Map()), (3,Map()))
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brennonyork/spark SPARK-5343

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4478
    
----
commit aa57f832e074d0285fdcdda35ea10b21625fe8e0
Author: Brennon York <brennon.york@capitalone.com>
Date:   2015-01-29T20:32:18Z

    updated to set ShortestPaths to run 'forward' rather than 'backward'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message