spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3885] Provide mechanism to remove accum...
Date Sat, 28 Feb 2015 20:03:07 GMT
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/4021#issuecomment-76543201
  
    > Actually, we won't leak accumulators on executors because we clear the thread-local
between tasks.
    
    At this point, I should have spotted that it doesn't make sense to store WeakReferences
if those references are going to be destroyed at the end of tasks anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message