spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-5984: Fix TimSort bug causes ArrayOutOfB...
Date Sat, 28 Feb 2015 02:24:55 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4804#discussion_r25552927
  
    --- Diff: core/src/test/java/org/apache/spark/util/collection/TestTimSort.java ---
    @@ -0,0 +1,133 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.util.collection;
    +
    +import java.util.*;
    +
    +/**
    + * This codes generates a int array which fails the standard TimSort.
    + *
    + * The blog that reported the bug
    + * http://www.envisage-project.eu/timsort-specification-and-verification/
    + *
    + * The algorithms to reproduce the bug is obtained from the reporter of the bug
    + * https://github.com/abstools/java-timsort-bug
    + *
    + * Licensed under Apache License 2.0
    + * https://github.com/abstools/java-timsort-bug/blob/master/LICENSE
    --- End diff --
    
    If this test code is your own work, then this statement is redundant with the license
header, so would be removed.
    
    But it's copied from the project above right? then you can't write a license header here
that says it was licensed to the ASF. If anything we would reproduce the plain vanilla AL2
stanza from the plain AL2 license text up above in the file's license header.
    
    That or not copy this test code. This Java code needs a bit more style work to match coding
practices here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message