spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...
Date Fri, 27 Feb 2015 18:06:51 GMT
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r25525230
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -313,6 +320,21 @@ private[spark] class Client(
         env("SPARK_YARN_MODE") = "true"
         env("SPARK_YARN_STAGING_DIR") = stagingDir
         env("SPARK_USER") = UserGroupInformation.getCurrentUser().getShortUserName()
    +    // If we logged in from keytab, make sure we copy the keytab to the staging directory
on
    --- End diff --
    
    this comment should probably be more like if we passed in a keytab. Whether we used it
to login or not before submitted is irrelevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message