spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From advancedxy <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6030][CORE] Don't alignSize the compute...
Date Thu, 26 Feb 2015 06:59:45 GMT
Github user advancedxy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4783#discussion_r25408258
  
    --- Diff: core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala ---
    @@ -59,6 +59,13 @@ class SizeEstimatorSuite
         assertResult(24)(SizeEstimator.estimate(new DummyClass4(null)))
         assertResult(48)(SizeEstimator.estimate(new DummyClass4(new DummyClass3)))
       }
    +  
    +  test("primitive wrapper objects") {
    --- End diff --
    
    Should I just use primitive wrapper classes or create dummy classes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message