spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4924] Add a library for launching Spark...
Date Tue, 24 Feb 2015 21:22:54 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3916#discussion_r25293777
  
    --- Diff: core/src/main/scala/org/apache/spark/launcher/WorkerCommandBuilder.scala ---
    @@ -0,0 +1,49 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.launcher
    +
    +import java.io.File
    +import java.util.{HashMap => JHashMap, List => JList, Map => JMap}
    +
    +import scala.collection.JavaConversions._
    +
    +import org.apache.spark.deploy.Command
    +
    +/**
    + * This class is used by CommandUtils. It uses some package-private APIs in SparkLauncher
and so
    + * needs to live in the same package as the rest of the library.
    + */
    +private[spark] class WorkerCommandBuilder(sparkHome: String, memoryMb: Int, command:
Command)
    +    extends AbstractCommandBuilder {
    +
    +  childEnv.putAll(command.environment)
    +  childEnv.put(CommandBuilderUtils.ENV_SPARK_HOME, sparkHome)
    +
    +  override def buildCommand(env: JMap[String, String]): JList[String] = {
    +    val cmd = buildJavaCommand(command.classPathEntries.mkString(File.pathSeparator))
    +    cmd.add(s"-Xms${memoryMb}M")
    +    cmd.add(s"-Xmx${memoryMb}M")
    +    command.javaOpts.foreach { cmd.add }
    +    addPermGenSizeOpt(cmd)
    +    addOptionString(cmd, getenv("SPARK_JAVA_OPTS"))
    +    cmd
    +  }
    +
    +  def buildCommand(): JList[String] = buildCommand(new JHashMap[String, String]())
    --- End diff --
    
    we should define a `def buildCommand()` that calls this with an empty map in the parent
Java class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message