spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5801] [core] Avoid creating nested dire...
Date Tue, 24 Feb 2015 20:25:30 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4747#discussion_r25288970
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
    @@ -135,7 +135,7 @@ private[spark] class ExecutorRunner(
           logInfo("Launch command: " + command.mkString("\"", "\" \"", "\""))
     
           builder.directory(executorDir)
    -      builder.environment.put("SPARK_LOCAL_DIRS", appLocalDirs.mkString(","))
    +      builder.environment.put("SPARK_EXECUTOR_DIRS", appLocalDirs.mkString(File.pathSeparator))
    --- End diff --
    
    I think these are dumb questions, but why does the fix entail setting a different env
variable? and should dirs be joined with a path separator?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message