spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5881][SQL] RDD remains cached after the...
Date Thu, 19 Feb 2015 09:50:00 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4689#discussion_r24975506
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/CacheManager.scala ---
    @@ -39,7 +39,7 @@ private case class CachedData(plan: LogicalPlan, cachedRepresentation:
InMemoryR
     private[sql] class CacheManager(sqlContext: SQLContext) extends Logging {
     
       @transient
    -  private val cachedData = new scala.collection.mutable.ArrayBuffer[CachedData]
    +  val cachedData = new scala.collection.mutable.ArrayBuffer[CachedData]
    --- End diff --
    
    Seems no need to make this public? Didn't find this referenced anywhere other than `CacheManager`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message