spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5817] [SQL] Fix bug of udtf with column...
Date Wed, 18 Feb 2015 03:56:40 GMT
Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/4602#issuecomment-74807564
  
    @chenghao-intel After another look of the code, I think it may be better to remove aliases
from the `generator`. Then, `MultiAlias` can be used to assign the names to the output fields
of a generator. Because a `Generator` is just an `Expression`, seems it is not a good idea
to put names in it. Instead, using an `NamedExpression` (e.g. `MultiAlias`) to wrap a `Generator`
looks like a better approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message