spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5799][SQL] Compute aggregation function...
Date Sat, 14 Feb 2015 09:46:45 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4592#discussion_r24713616
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala ---
    @@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
           queryExecution.analyzed.resolve(n.name, sqlContext.analyzer.resolver).get
         }
       }
    -
    + 
    +  protected[sql] def numericColumns(colNames: String*): Seq[Expression] = {
    --- End diff --
    
    I was suggesting removing this, and just resolve all the columns the user specified. I
don't think we should silently drop a column.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message