spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...
Date Fri, 13 Feb 2015 18:08:35 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2851#discussion_r24683430
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala ---
    @@ -118,8 +140,20 @@ class StorageStatus(val blockManagerId: BlockManagerId, val maxMem:
Long) {
             } else {
               None
             }
    +      case BroadcastBlockId(broadcastId, _) =>
    +        // Actually remove the block, if it exists
    +        if (_broadcastBlocks.contains(broadcastId)) {
    +          val removed = _broadcastBlocks(broadcastId).remove(blockId)
    +          // If the given RDD has no more blocks left, remove the RDD
    --- End diff --
    
    Please, don't do that. It is very hard to understand these kinds of extractors, especially
when RddOrBlockId itself doesn't have a real class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message