spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ryan-williams <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4666] Improve YarnAllocator's parsing o...
Date Fri, 13 Feb 2015 00:00:19 GMT
Github user ryan-williams commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3525#discussion_r24633577
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -203,6 +203,28 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging
{
         getOption(key).map(_.toBoolean).getOrElse(defaultValue)
       }
     
    +  // Limit of bytes for total size of results (default is 1GB)
    --- End diff --
    
    hm, I'd vote we put it back in `Utils` over un-factoring those two calls that are doing
the same thing as one another


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message