spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2996] Implement userClassPathFirst for ...
Date Mon, 09 Feb 2015 02:48:31 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3233#discussion_r24306886
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -782,7 +785,13 @@ object Client extends Logging {
     
       /**
        * Populate the classpath entry in the given environment map.
    -   * This includes the user jar, Spark jar, and any extra application jars.
    +   *
    +   * User jars are generally not added to the JVM's classpath; those are handled by the
AM and
    +   * executor backend. When the deprecated `spark.yarn.user.classpath.first` is used,
user jars are
    --- End diff --
    
    It would be clearer if you explicitly say that `those are loaded by the AM or the executor
backend dynamically`, because it's technically added to the JVM's class path, just that it's
added later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message