spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-4267 [CORE] Failing to launch jobs on Sp...
Date Sat, 07 Feb 2015 01:07:33 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/4188#issuecomment-73341528
  
    @vanzin I don't think it does build a big command line though. I see:
    
    ```
        val commands = prepareCommand(...) // List[String]
        ...
        ctx.setCommands(commands)
    ```
    
    The elements of that list can and should be escaped?
    If I update `YarnClusterSuite` to add a `spark.executor.extraJavaOptions` like `-Dfoo="one
two three"` then the test fails... although just adding this escaping routine to the args
in `ExecutorRunnable` too does not fix that. Still investigating...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message