spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From freeman-lab <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5601][MLLIB] make streaming linear algo...
Date Fri, 06 Feb 2015 21:36:47 GMT
Github user freeman-lab commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4432#discussion_r24273989
  
    --- Diff: mllib/src/test/java/org/apache/spark/mllib/regression/JavaStreamingLinearRegressionSuite.java
---
    @@ -0,0 +1,80 @@
    +/*
    --- End diff --
    
    Do you want to add a similar `JavaStreamingLogisticRegressionSuite`? Given that the primary
change here is to the base class (used by both linear and logistic regression), might make
sense to include in the same PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message