spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5182] [SPARK-5528] [SPARK-5509] [SPARK-...
Date Thu, 05 Feb 2015 02:37:49 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4308#discussion_r24139597
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
    @@ -81,117 +123,189 @@ private[parquet] case class Partition(partitionValues: Map[String,
Any], files:
      * discovery.
      */
     @DeveloperApi
    -case class ParquetRelation2(path: String)(@transient val sqlContext: SQLContext)
    -  extends CatalystScan with Logging {
    +case class ParquetRelation2
    +    (paths: Seq[String], parameters: Map[String, String], maybeSchema: Option[StructType]
= None)
    +    (@transient val sqlContext: SQLContext)
    +  extends CatalystScan
    +  with InsertableRelation
    +  with SparkHadoopMapReduceUtil
    +  with Logging {
    +
    +  // Should we merge schemas from all Parquet part-files?
    +  private val shouldMergeSchemas =
    +    parameters.getOrElse(ParquetRelation2.MERGE_SCHEMA, "true").toBoolean
    --- End diff --
    
    oh sorry, it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message