spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-5595][SPARK-5603][SQL] Add a rule to do...
Date Wed, 04 Feb 2015 23:38:53 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4373#discussion_r24131086
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -158,6 +158,20 @@ trait CatalystScan extends BaseRelation {
     }
     
     @DeveloperApi
    +/**
    + * ::DeveloperApi::
    + * A BaseRelation that can be used to insert data into it through the insert method.
    + * If overwrite in insert method is true, the old data in the relation should be overwritten
with
    + * the new data. If overwrite in insert method is false, the new data should be appended.
    + *
    + * InsertableRelation assumes that the data (Rows in the DataFrame) provided to the insert
method
    + * exactly matches the ordinal of fields in the schema of the BaseRelation.
    + * InsertableRelation assumes that the schema of this relation will not be changed.
    + * Even if the insert method updates the schema, the new schema cannot be used.
    + */
     trait InsertableRelation extends BaseRelation {
    +  /** If this relation treats fields with different nullability as the same fields */
    +  def ignoreNullability: Boolean
    --- End diff --
    
    I'd remove this and always assume `true`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message